Remove Tar archiving #4286
Merged
Remove Tar archiving #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyhappydan
previously approved these changes
Sep 20, 2023
...plugins/archive/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/archive/model/Zip.scala
Outdated
Show resolved
Hide resolved
...hive/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/archive/routes/ArchiveRoutes.scala
Outdated
Show resolved
Hide resolved
...chive/src/test/scala/ch/epfl/bluebrain/nexus/delta/plugins/archive/ArchiveDownloadSpec.scala
Outdated
Show resolved
Hide resolved
dantb
force-pushed
the
remove-tar-archives
branch
from
66a53bb to
925d7a5
Compare
|
@shinyhappydan I'm getting a failing test which doesn't fail locally 🤔 it fails on a future which populates a file from a stream |
imsdu
previously approved these changes
Sep 21, 2023
imsdu
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4050
ArchiveFormatabstractionZipdirectly. The zip-specific stuff is still grouped together in an object - this might be more readable and I suppose it saves some duplication at callsitesArchiveMetadatafor zipsArchiveDownloadSpecspecific to zips (no longer an abstract class)